Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

add angular devcontainer #12

Merged
merged 1 commit into from
Apr 17, 2019
Merged

add angular devcontainer #12

merged 1 commit into from
Apr 17, 2019

Conversation

bowdenk7
Copy link

No description provided.

@bowdenk7
Copy link
Author

@Chuxel what's the best way to test this?

@Chuxel
Copy link
Member

Chuxel commented Apr 16, 2019

@bowdenk7 I believe the only way to test the auto-pick up is to merge it in. It will then be in the next build of the Remote - Contaners extension.

@chrmarti Is there another trick I'm not aware of?

@Chuxel Chuxel merged commit 368cc61 into master Apr 17, 2019
@Chuxel
Copy link
Member

Chuxel commented Apr 17, 2019

Merging and bumping the vscode-dev-containers version so it gets picked up with next update to try it out

@chrmarti
Copy link
Contributor

You could copy it into the current install of the vscode-remote-containers extension (that will be overwritten by the next update).

It's a manual change to vscode-remote-containers to pick up a new version of vscode-dev-containers. (Currently it's copying the NPM package from the GitHub Releases page to the vscode-remote-containers repo.)

@chrmarti
Copy link
Contributor

@Chuxel When pushing a new version of vscode-dev-containers, you also need to push a tag, so the result is published on GitHub's Releases tab. There are many ways to do this, I find the easiest to be running npm version minor to do the version increment in package.json and add the tag. And then git push --follow-tags to push the change to package.json and the new tag.

Currently the tag is missing, I'll add that and then also update vscode-remote-containers. 👍

# Licensed under the MIT License. See LICENSE in the project root for license information.
#-----------------------------------------------------------------------------------------

FROM openjdk:7
Copy link

@jamiebarrow jamiebarrow Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bowdenk7, @Chuxel I was wondering if there was any specific reason to use openjdk:7 as the base image, and not some kind of NodeJS base image? For example, as in https://github.com/microsoft/vscode-dev-containers/blob/master/containers/javascript-node/.devcontainer/base.Dockerfile

Also, if this is the wrong place to be asking this, please ignore my ignorance :)

@Chuxel
Copy link
Member

Chuxel commented Feb 18, 2021

Angular actually has its own definition now, so I suspect we should just remove this one.

https://github.com/angular/angular/tree/master/.devcontainer

@jamiebarrow
Copy link

@Chuxel thanks for sharing :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants