-
Notifications
You must be signed in to change notification settings - Fork 1.4k
add angular devcontainer #12
Conversation
@Chuxel what's the best way to test this? |
Merging and bumping the vscode-dev-containers version so it gets picked up with next update to try it out |
You could copy it into the current install of the vscode-remote-containers extension (that will be overwritten by the next update). It's a manual change to vscode-remote-containers to pick up a new version of vscode-dev-containers. (Currently it's copying the NPM package from the GitHub Releases page to the vscode-remote-containers repo.) |
@Chuxel When pushing a new version of vscode-dev-containers, you also need to push a tag, so the result is published on GitHub's Releases tab. There are many ways to do this, I find the easiest to be running Currently the tag is missing, I'll add that and then also update vscode-remote-containers. 👍 |
# Licensed under the MIT License. See LICENSE in the project root for license information. | ||
#----------------------------------------------------------------------------------------- | ||
|
||
FROM openjdk:7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bowdenk7, @Chuxel I was wondering if there was any specific reason to use openjdk:7
as the base image, and not some kind of NodeJS base image? For example, as in https://github.com/microsoft/vscode-dev-containers/blob/master/containers/javascript-node/.devcontainer/base.Dockerfile
Also, if this is the wrong place to be asking this, please ignore my ignorance :)
Angular actually has its own definition now, so I suspect we should just remove this one. https://github.com/angular/angular/tree/master/.devcontainer |
@Chuxel thanks for sharing :) |
No description provided.